Jskinne3 lg 7653 intermittent tests 2#7159
Conversation
README.md
Outdated
| ulimit -Sn 65536 | ||
| ``` | ||
|
|
||
| If you are running MacOS, you may find it is not taking your revised ulimit seriously. [Insist by](https://medium.com/mindful-technology/too-many-open-files-limit-ulimit-on-mac-os-x-add0f1bfddde) adding the following file at `/Library/LaunchDaemons/limit.maxfiles.plist` and set it to be owned by root: |
There was a problem hiding this comment.
😭 I wish we didn't have to resort to this....
but as long as we're here, can we make it easier to copy paste? Like a chown command to copy? and maybe bonus like one of these cat commands to write to the file
cat > /Library/LaunchDaemons/limit.maxfiles.plist <<XML
<?xml ....
XMLThere was a problem hiding this comment.
A nice idea! Sadly I think that using cat > in a directory owned by root would require interactive sudo -i login, which I have a bad feeling about. The easiest way to do it in my opinion is to use sudo to launch the editor, then paste the file contents in. I've changed the README to reflect this!
There was a problem hiding this comment.
Since this requires root access are people that use GFEs allowed to do this?
Why? The capybara-selenium gem was last updated on 12/20/2014. The functionality of that gem has been replaced by the webdrivers gem.
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, worth a shot!
| group :test do | ||
| gem 'axe-core-rspec', '~> 4.2' | ||
| gem 'bundler-audit', require: false | ||
| gem 'capybara-selenium', '>= 0.0.6' |
There was a problem hiding this comment.
this is just because we no longer use selenium, right?
There was a problem hiding this comment.
the webdrivers gem contains all of the different webdrivers, and capybara-selenium hasn't been updated since 2014. This gem was just there to make capybara work with selenium, but that is handled with webdrivers now.
There was a problem hiding this comment.
Excellent! ✨ really glad to get that outdated gem outta there
3 participants
🎫 Ticket
LG-7653
https://cm-jira.usa.gov/browse/LG-7653
changelog: Added, README, increase file descriptor limit
🛠 Summary of changes
I added to the README some instructions for increasing limit of MacOS file descriptors. This resolves "too many open files" errors.
This is does not fix all intermittent test failures I'm experiencing -- this is just the only one I was able to conclusively fix. I suspect there is an underlying issue, like a connection which is failing to close and is not relinquishing its file descriptors.
References:
📜 Testing Plan
Confirm if you are among the MacBooks experiencing intermittent "too many open files" errors. If you are, follow the instructions to create a limit.maxfiles.plist file. Reboot your laptop and see if the errors go away.
🚀 Notes for Deployment
None because it is just a README change