Skip to content

LG-7415: Allow using mock TMX proofer when TMX JS disabled #6885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 3 commits into from
Sep 1, 2022
Merged

LG-7415: Allow using mock TMX proofer when TMX JS disabled #6885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0e7870
Allow using mock TMX proofer when TMX JS disabled
matthinz Aug 31, 2022
14aabcb
Update tests
matthinz Aug 31, 2022
0adbcd9
Update more tests mark 2
matthinz Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/services/idv/steps/ipp/ssn_step.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ def form_submit
end

def generate_threatmetrix_session_id
return unless IdentityConfig.store.proofing_device_profiling_collecting_enabled
flow_session[:threatmetrix_session_id] = SecureRandom.uuid if !updating_ssn
flow_session[:threatmetrix_session_id]
end
Expand Down
1 change: 0 additions & 1 deletion app/services/idv/steps/ssn_step.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ def invalid_state_response
end

def generate_threatmetrix_session_id
return unless IdentityConfig.store.proofing_device_profiling_collecting_enabled
flow_session[:threatmetrix_session_id] = SecureRandom.uuid if !updating_ssn
flow_session[:threatmetrix_session_id]
end
Expand Down
6 changes: 3 additions & 3 deletions spec/features/idv/doc_auth/verify_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@
anything,
should_proof_state_id: true,
trace_id: anything,
threatmetrix_session_id: nil,
threatmetrix_session_id: kind_of(String),
user_id: user.id,
request_ip: kind_of(String),
).
Expand All @@ -204,7 +204,7 @@
anything,
should_proof_state_id: false,
trace_id: anything,
threatmetrix_session_id: nil,
threatmetrix_session_id: kind_of(String),
user_id: user.id,
request_ip: kind_of(String),
).
Expand All @@ -229,7 +229,7 @@
anything,
should_proof_state_id: false,
trace_id: anything,
threatmetrix_session_id: nil,
threatmetrix_session_id: kind_of(String),
user_id: user.id,
request_ip: kind_of(String),
).
Expand Down
4 changes: 2 additions & 2 deletions spec/services/idv/steps/ipp/ssn_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,12 @@
end

context 'with proofing device profiling collecting disabled' do
it 'does not add a session id to flow session' do
it 'still adds a session id to flow session' do
allow(IdentityConfig.store).
to receive(:proofing_device_profiling_collecting_enabled).
and_return(false)
step.extra_view_variables
expect(flow.flow_session[:threatmetrix_session_id]).to eq(nil)
expect(flow.flow_session[:threatmetrix_session_id]).to_not eq(nil)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions spec/services/idv/steps/ssn_step_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,12 @@
end

context 'with proofing device profiling collecting disabled' do
it 'does not add a session id to flow session' do
it 'still adds a session id to flow session' do
allow(IdentityConfig.store).
to receive(:proofing_device_profiling_collecting_enabled).
and_return(false)
step.extra_view_variables
expect(flow.flow_session[:threatmetrix_session_id]).to eq(nil)
expect(flow.flow_session[:threatmetrix_session_id]).to_not eq(nil)
end
end
end
Expand Down