LG-7415: Allow using mock TMX proofer when TMX JS disabled#6885
Merged
LG-7415: Allow using mock TMX proofer when TMX JS disabled#6885
Conversation
zachmargolis
approved these changes
Aug 31, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, are there any specs we'd want to update to make sure the session ID is generated but the JS is still not included?
Contributor
|
You probably have to remove the spec in and |
Contributor
Author
This should be covered by https://github.com/18F/identity-idp/blob/matthinz/lg-7415-tmx-collecting-fix/spec/views/idv/shared/_ssn.html.erb_spec.rb#L79-L88 |
matthinz
force-pushed
the
matthinz/lg-7415-tmx-collecting-fix
branch
2 times, most recently
from
31d8a9e to
c6cf814
Compare
To support scenarios where `proofing_device_profiling_collecting_enabled` is `false` but `proofing_device_profiling_decisioning_enabled` is `true`, ensure we're generating `session_id` values for ThreatMetrix, even if we don't end up embedding the TMX javascript. changelog: Upcoming Features, ThreatMetrix, Allow using mock TMX proofer when TMX JS disabled
matthinz
force-pushed
the
matthinz/lg-7415-tmx-collecting-fix
branch
from
c6cf814 to
0adbcd9
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: We're trying to test ThreatMetrix in int, with collecting (TMX's third-party JS embed) disabled, but decisioning enabled via a mock, and we ran into an issue where the mock was not being called.
How: Rather than only generating a
threatmetrix_session_idvalue when collecting is enabled, we now always generate that ID and store it inflow_session. This does not affect the logic around including third party Javascript on the page (if collecting is disabled, no Javascript embed will be included).