Skip to content

Allow triggering different review_status values in mock DDP proofer #6829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthinz merged 2 commits into from
Aug 23, 2022
Merged

Allow triggering different review_status values in mock DDP proofer #6829

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbd878d
Allow triggering failures in mock DDP proofer
matthinz Aug 23, 2022
1700eb3
Add tests for DdpMockClient
matthinz Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion app/services/proofing/mock/ddp_mock_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,27 @@ class DdpMockClient < Proofing::Base

TRANSACTION_ID = 'ddp-mock-transaction-id-123'

# Trigger the "REJECT" status
REJECT_STATUS_SSN = '666-77-8888'

@zachmargolis zachmargolis Aug 23, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add unit tests for these?

@zachmargolis zachmargolis Aug 23, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an example for a different mock proofer: https://github.com/18F/identity-idp/blob/d87550c9897ea082cd93e16907daf318880c94f1/spec/services/proofing/mock/resolution_mock_client_spec.rb


# Trigger the "REVIEW" status
REVIEW_STATUS_SSN = '666-77-9999'

# Trigger a nil status
NIL_STATUS_SSN = '666-77-0000'

proof do |applicant, result|
result.transaction_id = TRANSACTION_ID
result.review_status = 'pass'
result.review_status = case SsnFormatter.format(applicant[:ssn])
when REJECT_STATUS_SSN
'reject'
when REVIEW_STATUS_SSN
'review'
when NIL_STATUS_SSN
nil
else
'pass'
end
end
end
end
Expand Down