Allow triggering different review_status values in mock DDP proofer#6829
Merged
Allow triggering different review_status values in mock DDP proofer#6829
Conversation
Add "magic" SSNs that will trigger 3 separate `review_status` values from the mock LexisNexis DDP proofer: | 666-77-8888 | `"reject"` | | 666-77-9999 | `"review"` | | 666-77-0000 | `nil` | This will support testing of the integration of the proofer into the ID verification flow. changelog: Internal, ThreatMetrix, Allow triggering failures in mock DDP proofer (LG-7016)
matthinz
force-pushed
the
matthinz/lg-7016-mock-ddp-updates
branch
from
3fbcf5e to
cbd878d
Compare
zachmargolis
approved these changes
Aug 23, 2022
| TRANSACTION_ID = 'ddp-mock-transaction-id-123' | ||
|
|
||
| # Trigger the "REJECT" status | ||
| REJECT_STATUS_SSN = '666-77-8888' |
Contributor
There was a problem hiding this comment.
Can we add unit tests for these?
Contributor
There was a problem hiding this comment.
Here's an example for a different mock proofer: https://github.com/18F/identity-idp/blob/d87550c9897ea082cd93e16907daf318880c94f1/spec/services/proofing/mock/resolution_mock_client_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 3 "magic" SSNs that will trigger
review_statusvalues from the mock LexisNexis DDP proofer:"reject""review"nilAny other SSN will return
pass, as before. This will support testing of the integration of the proofer into the ID verification flow.