-
Notifications
You must be signed in to change notification settings - Fork 166
LG-7131 - Implementation improve messaging for users. #6809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f83d36d
LG-7131 - Implementation improve messaging for users.
peggles2 1604b15
Updating forgot password mailer and layout / locales
43f36b3
Adding spec for password reset gpo mailer
db210b7
Fixing localization yaml formatting
4a2a011
Removing unused locales
64f877f
Adding updated version of the letter-warning svg
9f1b1e1
Update app/views/user_mailer/reset_password_instructions.html.erb
eric-gade a2a5b6d
Updaing spacing
d03ce0e
Altering use of variables in mailer layout/reset view
9ec926c
Fixing reset mailer template to conditionally render header
74691e5
Update app/views/user_mailer/reset_password_instructions.html.erb
eric-gade 505f28d
Empty commit for CI
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
app/views/user_mailer/reset_password_instructions.html.erb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
spec/features/users/password_reset_with_pending_profile_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| require 'rails_helper' | ||
|
|
||
| feature 'reset password with pending profile' do | ||
| include PersonalKeyHelper | ||
|
|
||
| let(:user) { create(:user, :signed_up) } | ||
|
|
||
| scenario 'password reset email includes warning for pending profile' do | ||
| profile = create( | ||
| :profile, | ||
| deactivation_reason: :gpo_verification_pending, | ||
| pii: { ssn: '666-66-1234', dob: '1920-01-01', phone: '+1 703-555-9999' }, | ||
| user: user, | ||
| ) | ||
| create(:gpo_confirmation_code, profile: profile) | ||
|
|
||
| trigger_reset_password_and_click_email_link(user.email) | ||
|
|
||
| html_body = ActionMailer::Base.deliveries.last.html_part.body.decoded | ||
| expect(html_body).to include( | ||
| t('user_mailer.reset_password_instructions.gpo_letter_description'), | ||
| ) | ||
| end | ||
|
|
||
| scenario 'password reset email does not include warning without pending profile' do | ||
| trigger_reset_password_and_click_email_link(user.email) | ||
|
|
||
| html_body = ActionMailer::Base.deliveries.last.html_part.body.decoded | ||
| expect(html_body).to_not include( | ||
| t('user_mailer.reset_password_instructions.gpo_letter_description'), | ||
| ) | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.