LG-7131 - Implementation improve messaging for users.#6809
Merged
Conversation
-- What This commit updates the mailer template to better match the designs. It also adds conditionals to the parent layout template so that if there is a letter pending a different header will be ignored (the subject of the email) changelog: Improvements, Styling, Updating mailer format
changelog: Improvements, Email, adding tests for password reset mailer
changelog: Improvements, Emails, localization formatting
changelog Improvements, Email, updating locales
changelog: Improvements, Emails, updating svg for mailer
peggles2
commented
Aug 29, 2022
Contributor
Author
peggles2
left a comment
peggles2
left a comment
There was a problem hiding this comment.
Looks good! just minor tweaks.
| <td class="s30" height="30px"> | ||
| | ||
| </td> | ||
| <td class="s30" height="30px"> |
Contributor
Author
There was a problem hiding this comment.
I think we should keep it at 2 spaces for readability not 4 spaces.
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
changelog: Improvements, Email Notifications, updating password reset mailer
aduth
reviewed
Aug 29, 2022
eric-gade
force-pushed
the
LG-7131-gpo-letter-reset-password
branch
from
91d699b to
d03ce0e
Compare
aduth
reviewed
Aug 29, 2022
changelog: Improvements, Email, updating reset email header
aduth
approved these changes
Aug 30, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
One comment, but overall looks good 👍
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
changelog: Improvements, Email Notifications, updating forgot password mailer
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft ---