Merged
Conversation
**Why**: This code was implemented but never used in production. Drift has made it such that it no longer works.
Contributor
Author
|
There's a good bit of stuff to pull out here so this is still very much WIP |
Contributor
Author
|
Okay, I think I got everything. This should be ready for review |
app/models/gpo_confirmation_code.rb
Outdated
| class GpoConfirmationCode < ApplicationRecord | ||
| self.table_name = 'usps_confirmation_codes' | ||
|
|
||
| self.ignored_columns = %(bounced_at) |
Contributor
There was a problem hiding this comment.
This is a single string, I think we want an array of strings
Suggested change
| self.ignored_columns = %(bounced_at) | |
| self.ignored_columns = %w(bounced_at) |
Contributor
Author
There was a problem hiding this comment.
why do i even use % literals? I have no idea how they work
aduth
approved these changes
Aug 18, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Looks great! Glad we could remove this added complexity.
aduth
reviewed
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: This code was implemented but never used in production. Drift has made it such that it no longer works.