LG-7303 - send IP address to TMX, LG-7304 - send app_id to TMX

[gsa-manish]

LG-7303 - send IP address to TMX, LG-7304 - send app_id to TMX

changelog: Internal, DDP Proofer, send ip_address and app_id to API

[zachmargolis]

can we turn this into keyword args? They're much clearer about what inputs are needed

[gsa-manish]

done

[zachmargolis]

Hi sorry to be clear, I meant, "can we use the keyword arguments syntax" not just rename this to args. This is more of what I meant:

  def proof_lexisnexis_ddp_with_threatmetrix_if_needed(
    applicant_pii:,
    user_id:,
    threatmetrix_session_id:,
    request_ip:,
    uuid_prefix:
  )

[gsa-manish]

I tried that, there's a code climate limitation, which is why I went this way. Any other ideas to get around this?

Method proof_lexisnexis_ddp_with_threatmetrix_if_needed has 5 arguments (exceeds 4 allowed). Consider refactoring. NEW
def proof_lexisnexis_ddp_with_threatmetrix_if_needed(applicant_pii, user, threatmetrix_session_id, request_ip, uuid_prefix)
Severity: MinorFound in app/jobs/resolution_proofing_job.rb - About 35 mins to fix

[zachmargolis]

LGTM