Skip to content

Use RenderConditionConcern consistently for feature-guarding controllers#6757

Merged
aduth merged 2 commits intomainfrom
aduth-render-condition
Aug 16, 2022
Merged

Use RenderConditionConcern consistently for feature-guarding controllers#6757
aduth merged 2 commits intomainfrom
aduth-render-condition

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Aug 16, 2022

Context: #6624 (comment)

Why:

  • The intent of the concern is to DRY this common behavior
  • Include USPS locations controller as feature-guarded by IPP

**Why**:

- The intent of the concern is to DRY this common behavior
- Include USPS locations controller as feature-guarded by IPP
@aduth aduth requested a review from tomas-nava August 16, 2022 15:26
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changelog: Internal, Code Quality, Use common helper for feature-flagged routes
@aduth aduth merged commit 53a6582 into main Aug 16, 2022
@aduth aduth deleted the aduth-render-condition branch August 16, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants