Skip to content

LG-7132: Make the date parsing in TrueID Response more robust. #6683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solipet merged 7 commits into from
Aug 3, 2022
Merged

LG-7132: Make the date parsing in TrueID Response more robust. #6683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f69ba93
LG-7132: Make the date parsing in TrueID Response more robust.
solipet Aug 3, 2022
5408a86
don't worry about which part of the date was invalid
solipet Aug 3, 2022
00c6789
instead of adding a new fixture, test the private parse_date method
solipet Aug 3, 2022
e238597
Updates the spec to confirm that the error is logged and results in nil.
solipet Aug 3, 2022
b484da0
no need to guard month/day values
solipet Aug 3, 2022
697d7b7
rescue ArgumentError. typo in spec
solipet Aug 3, 2022
48bf7ac
lints
solipet Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/services/doc_auth/lexis_nexis/responses/true_id_response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,13 @@ def transform_metrics(img_metrics)
end

def parse_date(year:, month:, day:)
if year.to_i.positive? && month.to_i.positive? && day.to_i.positive?
Date.new(year.to_i, month.to_i, day.to_i).to_s
end
Date.new(year.to_i, month.to_i, day.to_i).to_s if year.to_i.positive?
rescue ArgumentError
message = {
event: 'Failure to parse TrueID date',
}.to_json
Rails.logger.info(message)
nil
end
end
end
Expand Down
19 changes: 19 additions & 0 deletions spec/services/doc_auth/lexis_nexis/responses/true_id_response_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,25 @@
end
end

describe '#parse_date' do
let(:response) { described_class.new(success_response, false, config) }

it 'handles an invalid month' do
expect(Rails.logger).to receive(:info)
expect(response.send(:parse_date, year: 2022, month: 13, day: 1)).to eq(nil)
end

it 'handles an invalid leap day' do
expect(Rails.logger).to receive(:info)
expect(response.send(:parse_date, year: 2022, month: 2, day: 29)).to eq(nil)
end

it 'handles a day past the end of the month' do
expect(Rails.logger).to receive(:info)
expect(response.send(:parse_date, year: 2022, month: 4, day: 31)).to eq(nil)
end
end

describe '#attention_with_barcode?' do
let(:response) { described_class.new(success_response, false, config) }
subject(:attention_with_barcode) { response.attention_with_barcode? }
Expand Down