LG-7132: Make the date parsing in TrueID Response more robust.#6683
Merged
LG-7132: Make the date parsing in TrueID Response more robust.#6683
Conversation
changelog: Bug Fixes, Document Authentication, Don't throw an exception on a bad DOB/Expiraton.
solipet
force-pushed
the
dprice-lg-7132-date-parsing-bug
branch
from
ed17302 to
f69ba93
Compare
zachmargolis
reviewed
Aug 3, 2022
spec/services/doc_auth/lexis_nexis/responses/true_id_response_spec.rb
Outdated
Show resolved
Hide resolved
zachmargolis
approved these changes
Aug 3, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, thanks for making those changes! These comments are optional but I think might make things clearer about what we want
app/services/doc_auth/lexis_nexis/responses/true_id_response.rb
Outdated
Show resolved
Hide resolved
spec/services/doc_auth/lexis_nexis/responses/true_id_response_spec.rb
Outdated
Show resolved
Hide resolved
aduth
approved these changes
Aug 3, 2022
app/services/doc_auth/lexis_nexis/responses/true_id_response.rb
Outdated
Show resolved
Hide resolved
mitchellhenke
approved these changes
Aug 3, 2022
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw some 500s being returned caused by a DateInvalid error being thrown. This PR ensures that the dates being parsed are valid, or logs a message when they aren't (not including the date since it's PII).