Lg 6797 services specs and clean up#6648
Merged
gangelo merged 5 commits intolg-6797-va-user-request-and-response-for-piifrom Jul 28, 2022
Merged
Lg 6797 services specs and clean up#6648gangelo merged 5 commits intolg-6797-va-user-request-and-response-for-piifrom
gangelo merged 5 commits intolg-6797-va-user-request-and-response-for-piifrom
Conversation
Add a spec helper to get the private key we need for our tests
…797-services-specs-and-clean-up
gangelo
approved these changes
Jul 28, 2022
holytoastr
added a commit
that referenced
this pull request
Jul 29, 2022
* Retrieve PII from VA Inherited Proofing API Add a spec helper to get the private key we need for our tests * Set up service specs * Update uri * Spec clean up Co-authored-by: gangelo <web.gma@gmail.com>
holytoastr
added a commit
that referenced
this pull request
Aug 1, 2022
* Retrieve PII from VA Inherited Proofing API changelog: Upcoming Features, Inherited Proofing, VA User Request and Response for PII (LG-6797) * Lg 6797 services specs and clean up (#6648) * Retrieve PII from VA Inherited Proofing API Add a spec helper to get the private key we need for our tests * Set up service specs * Update uri * Spec clean up Co-authored-by: gangelo <web.gma@gmail.com> * Use IdentityConfig.store for VA IP base url * Remove Identity::Hostdata.in_datacenter? guard * Linting and cleanup Co-authored-by: Melissa Miller <lis.d.miller@gmail.com> Co-authored-by: Melissa Miller <melissa.miller@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LG-6797 Service Specs and Clean Up
Round 2, this time without it getting wiped!
Why:
changelog: Automated Testing