Skip to content

Lg 6797 services specs and clean up#6648

Merged
gangelo merged 5 commits intolg-6797-va-user-request-and-response-for-piifrom
lg-6797-services-specs-and-clean-up
Jul 28, 2022
Merged

Lg 6797 services specs and clean up#6648
gangelo merged 5 commits intolg-6797-va-user-request-and-response-for-piifrom
lg-6797-services-specs-and-clean-up

Conversation

@holytoastr
Copy link
Contributor

LG-6797 Service Specs and Clean Up

Round 2, this time without it getting wiped!

Why:

  • Testing that the service specs that handle the VA IP call are behaving as expected when we receive a response

changelog: Automated Testing

gangelo and others added 4 commits July 27, 2022 10:46
@holytoastr holytoastr requested a review from gangelo July 28, 2022 15:37
@holytoastr holytoastr self-assigned this Jul 28, 2022
@gangelo gangelo merged this pull request into lg-6797-va-user-request-and-response-for-pii Jul 28, 2022
@gangelo gangelo deleted the lg-6797-services-specs-and-clean-up branch July 28, 2022 16:00
holytoastr added a commit that referenced this pull request Jul 29, 2022
* Retrieve PII from VA Inherited Proofing API

Add a spec helper to get the private key we need for our tests

* Set up service specs

* Update uri

* Spec clean up

Co-authored-by: gangelo <web.gma@gmail.com>
holytoastr added a commit that referenced this pull request Aug 1, 2022
* Retrieve PII from VA Inherited Proofing API

changelog: Upcoming Features, Inherited Proofing, VA User Request and Response for PII (LG-6797)

* Lg 6797 services specs and clean up (#6648)

* Retrieve PII from VA Inherited Proofing API

Add a spec helper to get the private key we need for our tests

* Set up service specs

* Update uri

* Spec clean up

Co-authored-by: gangelo <web.gma@gmail.com>

* Use IdentityConfig.store for VA IP base url

* Remove Identity::Hostdata.in_datacenter? guard

* Linting and cleanup

Co-authored-by: Melissa Miller <lis.d.miller@gmail.com>
Co-authored-by: Melissa Miller <melissa.miller@gsa.gov>
@rnagilla-gsa rnagilla-gsa added the inherited proofing Pull Requests for the Inherited Proofing feature label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inherited proofing Pull Requests for the Inherited Proofing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants