[LG-6797] VA Request and Response for User PII#6608
Merged
holytoastr merged 5 commits intomainfrom Aug 1, 2022
Merged
Conversation
gangelo
force-pushed
the
lg-6797-va-user-request-and-response-for-pii
branch
from
c988941 to
190aa13
Compare
app/services/inherited_proofing/va/user_attributes/user_attributes_request.rb
Outdated
Show resolved
Hide resolved
gangelo
force-pushed
the
lg-6797-va-user-request-and-response-for-pii
branch
8 times, most recently
from
a504b1a to
05caa3f
Compare
gangelo
force-pushed
the
lg-6797-va-user-request-and-response-for-pii
branch
7 times, most recently
from
c681bb9 to
f9b79a7
Compare
jmhooper
reviewed
Jul 26, 2022
app/services/inherited_proofing/va/service_payload_validator.rb
Outdated
Show resolved
Hide resolved
jmhooper
reviewed
Jul 26, 2022
app/services/inherited_proofing/va/service_payload_validator.rb
Outdated
Show resolved
Hide resolved
jmhooper
reviewed
Jul 26, 2022
app/services/inherited_proofing/va/service_payload_validator.rb
Outdated
Show resolved
Hide resolved
jmhooper
reviewed
Jul 26, 2022
gangelo
force-pushed
the
lg-6797-va-user-request-and-response-for-pii
branch
7 times, most recently
from
3648063 to
c1ab9ba
Compare
gangelo
force-pushed
the
lg-6797-va-user-request-and-response-for-pii
branch
2 times, most recently
from
c5cea5c to
b844a67
Compare
Contributor
|
PR lgtm, aside from failing CI. (Which don't seem to be related to your stuff, so not sure how we should handle that.) |
gangelo
force-pushed
the
lg-6797-va-user-request-and-response-for-pii
branch
from
a316f6b to
26cbd54
Compare
gangelo
force-pushed
the
lg-6797-va-user-request-and-response-for-pii
branch
from
c623188 to
ed39f7b
Compare
changelog: Upcoming Features, Inherited Proofing, VA User Request and Response for PII (LG-6797)
* Retrieve PII from VA Inherited Proofing API Add a spec helper to get the private key we need for our tests * Set up service specs * Update uri * Spec clean up Co-authored-by: gangelo <web.gma@gmail.com>
holytoastr
force-pushed
the
lg-6797-va-user-request-and-response-for-pii
branch
from
d9e0557 to
48d3c88
Compare
holytoastr
approved these changes
Aug 1, 2022
Contributor
holytoastr
left a comment
holytoastr
left a comment
There was a problem hiding this comment.
A great start to an awesome feature!
Merged
rnagilla-gsa
added
the
inherited proofing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes a request to the VA api for user PII and handles the response.