Skip to content

LG-7004-configs-threatmetrix #6637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gsa-manish merged 3 commits into from
Jul 28, 2022
Merged

LG-7004-configs-threatmetrix #6637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2260e1f
LG-7004-configs-threatmatrix
gsa-manish Jul 27, 2022
105b9ca
Update config/application.yml.default
gsa-manish Jul 27, 2022
d89ea08
Fixed name spelling
gsa-manish Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions config/application.yml.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,15 @@ lexisnexis_trueid_liveness_nocropping_workflow: customers.gsa.trueid.workflow
lexisnexis_trueid_noliveness_cropping_workflow: customers.gsa.trueid.workflow
lexisnexis_trueid_noliveness_nocropping_workflow: customers.gsa.trueid.workflow
###################################################################
# LexisNexis ThreatMetrix ##########################################
lexisnexis_threatmetrix_base_url: https://www.example.com
lexisnexis_threatmetrix_request_mode: testing
lexisnexis_threatmetrix_account_id: test_account
lexisnexis_threatmetrix_username: test_username
lexisnexis_threatmetrix_password: test_password
lexisnexis_threatmetrix_instant_verify_timeout: 1.0
lexisnexis_threatmetrix_instant_verify_workflow: customers.gsa.instant.verify.workflow
Comment on lines +150 to +151
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Jul 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry one more thing, threatmetrix is one product, instant verify is another, we're going to be using them separetly, so we should make that clearer:

Suggested change
lexisnexis_threatmetrix_instant_verify_timeout: 1.0
lexisnexis_threatmetrix_instant_verify_workflow: customers.gsa.instant.verify.workflow
lexisnexis_threatmetrix_timeout: 1.0
lexisnexis_threatmetrix_workflow: customers.gsa.instant.verify.workflow

Copy link
Copy Markdown
Contributor

@aduth aduth Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the sample value also reflect that? i.e. customers.gsa.threat.metrix.workflow instead of customers.gsa.instant.verify.workflow

Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hindsight, yes that might be nice to update to a more realistic placeholder, but since it's a sample we should be replacing it anyways and I'm not super worried about it

###################################################################
lockout_period_in_minutes: 10
log_to_stdout: false
logins_per_email_and_ip_bantime: 60
Expand Down
7 changes: 7 additions & 0 deletions lib/identity_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,13 @@ def self.build_store(config_map)
config.add(:lexisnexis_trueid_noliveness_cropping_workflow, type: :string)
config.add(:lexisnexis_trueid_noliveness_nocropping_workflow, type: :string)
config.add(:lexisnexis_trueid_timeout, type: :float)
config.add(:lexisnexis_threatmetrix_base_url, type: :string)
config.add(:lexisnexis_threatmetrix_request_mode, type: :string)
config.add(:lexisnexis_threatmetrix_account_id, type: :string)
config.add(:lexisnexis_threatmetrix_username, type: :string)
config.add(:lexisnexis_threatmetrix_password, type: :string)
config.add(:lexisnexis_threatmetrix_instant_verify_timeout, type: :float)
config.add(:lexisnexis_threatmetrix_instant_verify_workflow, type: :string)
config.add(:liveness_checking_enabled, type: :boolean)
config.add(:lockout_period_in_minutes, type: :integer)
config.add(:log_to_stdout, type: :boolean)
Expand Down