Merged
Conversation
changelog: Upcoming Features, Config, Add ThreatMatrix configs - LG-7004
gsa-manish
force-pushed
the
LG-7004-configs-threatmatrix
branch
from
885d900 to
2260e1f
Compare
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
jskinne3
suggested changes
Jul 27, 2022
Contributor
jskinne3
left a comment
jskinne3
left a comment
There was a problem hiding this comment.
The typo "threatmatrix" is still present in the identity_config.rb file
jskinne3
approved these changes
Jul 27, 2022
Contributor
jskinne3
left a comment
jskinne3
left a comment
There was a problem hiding this comment.
:dust-off-hands-gesture:
Comment on lines
+150
to
+151
| lexisnexis_threatmetrix_instant_verify_timeout: 1.0 | ||
| lexisnexis_threatmetrix_instant_verify_workflow: customers.gsa.instant.verify.workflow |
Contributor
There was a problem hiding this comment.
sorry one more thing, threatmetrix is one product, instant verify is another, we're going to be using them separetly, so we should make that clearer:
Suggested change
| lexisnexis_threatmetrix_instant_verify_timeout: 1.0 | |
| lexisnexis_threatmetrix_instant_verify_workflow: customers.gsa.instant.verify.workflow | |
| lexisnexis_threatmetrix_timeout: 1.0 | |
| lexisnexis_threatmetrix_workflow: customers.gsa.instant.verify.workflow |
Contributor
There was a problem hiding this comment.
Should the sample value also reflect that? i.e. customers.gsa.threat.metrix.workflow instead of customers.gsa.instant.verify.workflow
Contributor
There was a problem hiding this comment.
In hindsight, yes that might be nice to update to a more realistic placeholder, but since it's a sample we should be replacing it anyways and I'm not super worried about it
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.