Skip to content

LG-6577: Show error page when FSMv2 React application crashes#6509

Merged
aduth merged 5 commits intomainfrom
aduth-lg-6577-fsmv2-react-crash
Jun 22, 2022
Merged

LG-6577: Show error page when FSMv2 React application crashes#6509
aduth merged 5 commits intomainfrom
aduth-lg-6577-fsmv2-react-crash

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jun 17, 2022

Why: As a user, I expect that I am informed if there is an issue with the application, so that I know what my options are for continuing.

Screenshot:

Screen Shot 2022-06-21 at 10 26 16 AM

Testing Instructions:

  1. Follow "Steps to reproduce" outlined in LG-6576

Before: You see a blank page upon reaching the "Please re-enter your password" step
After: You see the error page as in the screenshot above

@aduth aduth marked this pull request as ready for review June 21, 2022 14:44
@aduth aduth requested a review from a team June 21, 2022 14:44
Comment on lines 86 to 103
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to handle this logic inside the components so that we can have ErrorBoundary dealing with all errors and not have to duplicate as much. Not sure how straight-forward a refactor that would be and if it'd be best to do here vs. a separate pull request.

aduth added 5 commits June 22, 2022 08:18
**Why**: As a user, I expect that I am informed if there is an issue with the application, so that I know what my options are for continuing.

changelog: Upcoming Features, Identity Verification, Add application crash handling error page
@aduth aduth force-pushed the aduth-lg-6577-fsmv2-react-crash branch from aa3147d to 4de30e2 Compare June 22, 2022 12:29
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

},
]}
/>
{inPersonURL && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tomas-nava @sheldon-b looks like we're adding one more page that links to IPP, something to consider when adding the intro + location select in React

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it might be nice to consolidate this with DocumentCaptureTroubleshootingOptions, but as it stands, the options are pretty different than the ones we have there.

I suppose another idea could be to at least extract a common IPP troubleshooting options to share between these two and any future usage, if that would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants