Merged
Conversation
ca81e92 to
18f304d
Compare
changelog: Bug Fixes, Account Cancellation, Fix validation and deletion of account deletion attempts during sign up
18f304d to
0131c72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the intersection of a couple things. Initially, the goal was to continue reducing the number of
DeprecatedUserAttributesand I noticed the only place theconfirmation_tokenon theuserstable was being directly queried was when cancelling account sign up. The column is already unused and null, meaning the account cancellation was not working as intended. There is also a bit of crossover with #6247 (where we were not properly validating the email confirmation token).The combination of problems resulted in a few changes:
EmailAddressinstead ofUserconfirmation_tokenandconfirmation_sent_aton theuserstable. The tests were a bit tricky in this regard since they depended on theEmailAddressCallbackfunctionality to copy those attributes from the User model to EmailAddress.