Skip to content

Fix validation of confirmation_token on both showing and submitting email confirmation form#6247

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/fix-confirmation-token-validation
Apr 25, 2022
Merged

Fix validation of confirmation_token on both showing and submitting email confirmation form#6247
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/fix-confirmation-token-validation

Conversation

@mitchellhenke
Copy link
Contributor

No description provided.

@mitchellhenke mitchellhenke requested review from aduth and jmhooper April 25, 2022 14:15
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting this validation check in the stop_if_invalid_token is the key part of the change to ensure that tokens are fully validated, rather than only checking if @email_address is present

…mail confirmation form

changelog: Bug Fixes, Authentication, Ensure validation of email confirmation tokens is consistent
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/fix-confirmation-token-validation branch from 58e7143 to ffcae8e Compare April 25, 2022 14:28
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mitchellhenke mitchellhenke merged commit 4a67c1e into main Apr 25, 2022
@mitchellhenke mitchellhenke deleted the mitchellhenke/fix-confirmation-token-validation branch April 25, 2022 14:40
mitchellhenke pushed a commit that referenced this pull request Apr 25, 2022
…mail confirmation form (#6247)

changelog: Bug Fixes, Authentication, Ensure validation of email confirmation tokens is consistent
@jmdembe jmdembe mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants