changelog: content, backup codes, LG-6357#6400
Conversation
| clave de seguridad. | ||
| - Le otorgaremos 10 códigos que puede descargar, imprimir, copiar o | ||
| escribir. Ingresará un código cada vez que inicie sesión. | ||
| are_you_sure_title: '¿Está seguro de que desea usar códigos de respaldo?' |
There was a problem hiding this comment.
Spanish appears to be the only language with single quotes around the text, maybe the quotes should be removed?
There was a problem hiding this comment.
That is, for the key are_you_sure_title
There was a problem hiding this comment.
Good question. That field was in quotes before, as are many in the es yml. I assumed it was because of the special characters 🤷
There was a problem hiding this comment.
I believe for Spanish text, any kind of punctuation has to be escaped because it does not render the text as expected. I ran into this one, but I do not remember where...
|
When we squash and merge this can we make sure to give it a descriptive title and body to help people going through the log or blame in the future some context for this change? |
4 participants
Ticket for change is here: https://cm-jira.usa.gov/browse/LG-6357
Figma for change is here: https://www.figma.com/file/wIOL0ZP4aZvMUjKKuCG2u2/LG-6344-Backup-codes-copy-changes?node-id=0%3A1
Translations are from Gengo.
Running locally:
Deployed to https://idp.ssteiner.identitysandbox.gov/ for testing.