Merged
Conversation
**Why**: So that we can more easily ensure consistent indentation, improving readability. changelog: Internal, Code Quality, Apply and enforce consistent code indentation
aduth
force-pushed
the
aduth-rubocop-indentation
branch
from
1267c27 to
0301595
Compare
mdiarra3
approved these changes
May 23, 2022
Comment on lines
+624
to
+628
| track_event( | ||
| 'IdV: USPS address visited', | ||
| letter_already_sent: letter_already_sent, | ||
| **extra, | ||
| ) |
Contributor
There was a problem hiding this comment.
this is a good catch 👍
To address indentation constraints Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that we can more easily ensure consistent indentation, improving readability.
Most of this is pretty straight-forward. The one notable exception is conditional assignment, which expects indentation of the next line to match the assignment operator, leading to some tight column width constraints. For a few of these, I refactored them to ternaries, which don't have the same expectation of alignment to the assignment operator.
Certainly easiest to review with whitespace changes hidden: https://github.com/18F/identity-idp/pull/6395/files?w=1