Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,10 @@ Layout/IndentationConsistency:

Layout/IndentationStyle:
Enabled: true
IndentationWidth: null

Layout/IndentationWidth:
Enabled: true

Layout/InitialIndentation:
Enabled: true

Expand Down
3 changes: 2 additions & 1 deletion app/jobs/address_proofing_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ def perform(user_id:, issuer:, result_id:, encrypted_arguments:, trace_id:)
private

def address_proofer
@address_proofer ||= if IdentityConfig.store.proofer_mock_fallback
@address_proofer ||=
if IdentityConfig.store.proofer_mock_fallback
Proofing::Mock::AddressMockClient.new
else
Proofing::LexisNexis::PhoneFinder::Proofer.new(
Expand Down
6 changes: 4 additions & 2 deletions app/jobs/resolution_proofing_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ def proof_state_id(applicant_pii:, result:)
end

def resolution_proofer
@resolution_proofer ||= if IdentityConfig.store.proofer_mock_fallback
@resolution_proofer ||=
if IdentityConfig.store.proofer_mock_fallback
Proofing::Mock::ResolutionMockClient.new
else
Proofing::LexisNexis::InstantVerify::Proofer.new(
Expand All @@ -202,7 +203,8 @@ def resolution_proofer
end

def state_id_proofer
@state_id_proofer ||= if IdentityConfig.store.proofer_mock_fallback
@state_id_proofer ||=
if IdentityConfig.store.proofer_mock_fallback
Proofing::Mock::StateIdMockClient.new
else
Proofing::Aamva::Proofer.new(
Expand Down
3 changes: 2 additions & 1 deletion app/models/throttle.rb
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ class Throttle < ApplicationRecord
# @param [User] user
# @return [Throttle]
def self.for(throttle_type:, user: nil, target: nil)
throttle = if user
throttle =
if user
find_or_create_by(user: user, throttle_type: throttle_type)
elsif target
if !target.is_a?(String)
Expand Down
7 changes: 3 additions & 4 deletions app/services/idv/actions/verify_document_action.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,11 @@ def form
end

def enqueue_job
verify_document_capture_session = if hybrid_flow_mobile?
verify_document_capture_session =
if hybrid_flow_mobile?
document_capture_session
else
create_document_capture_session(
verify_document_capture_session_uuid_key,
)
create_document_capture_session(verify_document_capture_session_uuid_key)
end
verify_document_capture_session.requested_at = Time.zone.now
verify_document_capture_session.create_doc_auth_session
Expand Down
3 changes: 2 additions & 1 deletion app/services/idv/actions/verify_document_status_action.rb
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ def process_result(async_state)

def verify_document_capture_session
return @verify_document_capture_session if defined?(@verify_document_capture_session)
@verify_document_capture_session = if hybrid_flow_mobile?
@verify_document_capture_session =
if hybrid_flow_mobile?
document_capture_session
else
DocumentCaptureSession.find_by(
Expand Down
3 changes: 2 additions & 1 deletion app/services/secure_headers_allow_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ def self.csp_with_sp_redirect_uris(action_url_domain, sp_redirect_uris)
def self.reduce_sp_redirect_uris_for_csp(uris)
csp_uri_set = uris.each_with_object(Set.new) do |uri, uri_set|
parsed_uri = URI.parse(uri)
reduced_uri = if parsed_uri.scheme.match?(/\Ahttps?\z/)
reduced_uri =
if parsed_uri.scheme.match?(/\Ahttps?\z/)
reduce_web_sp_uri(parsed_uri)
else
reduce_native_app_sp_uri(parsed_uri)
Expand Down
3 changes: 1 addition & 2 deletions app/views/idv/shared/_error.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ else
image_src = 'status/warning.svg'
troubleshooting_heading = t('components.troubleshooting_options.default_heading')
alt = t('errors.alt.warning')
end
%>
end %>
<% title local_assigns.fetch(:title, heading) %>
<%= image_tag(image_src, width: 54, alt: alt, class: 'display-block margin-bottom-4') %>

Expand Down
3 changes: 2 additions & 1 deletion lib/telephony/pinpoint/sms_sender.rb
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ def error(message_response_result)
status_code = message_response_result.status_code
delivery_status = message_response_result.delivery_status
exception_message = "Pinpoint Error: #{delivery_status} - #{status_code}"
exception_class = if permanent_failure_opt_out?(message_response_result)
exception_class =
if permanent_failure_opt_out?(message_response_result)
OptOutError
else
ERROR_HASH[delivery_status] || TelephonyError
Expand Down