Skip to content

LG-6120 SSN alt image #6390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nprimak merged 2 commits into from
May 23, 2022
Merged

LG-6120 SSN alt image #6390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ed04ea
add alt tag to ssn image same as image above
nprimak May 20, 2022
70336f0
Add changelog
nprimak May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/sign_up/registrations/_required_pii_accordion.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<p class="grid-row grid-gutter">
<%= image_tag(
asset_url('get-started/personal-details.svg'),
size: '40', alt: '', class: 'margin-top-05 grid-col-auto',
size: '40', alt: t('devise.registrations.start.bullet_3_img'), class: 'margin-top-05 grid-col-auto',
Copy link
Copy Markdown
Contributor

@aduth aduth May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's correct as-is, but just to double-check, this is meant to be 3, and not 4? Since the sequence here is bullet_3_img, bullet_3_img, bullet_5_img. I guess since it's the same image as the previous bullet point, it's sensible for it to also have the same alt text?

Copy link
Copy Markdown
Contributor Author

@nprimak nprimak May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I was on the fence about whether to change the name to something like "bullet_3_4_img" to make it clearer but ultimately thought that was still a little weird and it would be redundant to have it written in the translation doc twice

Copy link
Copy Markdown
Contributor

@aduth aduth May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and as mentioned in the previous pull request, it'd be good to move away from the "bullet_#" convention anyways, so wouldn't want to make that harder.

All good then 👍

) %>
<span class="grid-col-fill padding-left-2">
<%= t('devise.registrations.start.bullet_4_html') %>
Expand Down