Conversation
| <%= image_tag( | ||
| asset_url('get-started/personal-details.svg'), | ||
| size: '40', alt: '', class: 'margin-top-05 grid-col-auto', | ||
| size: '40', alt: t('devise.registrations.start.bullet_3_img'), class: 'margin-top-05 grid-col-auto', |
There was a problem hiding this comment.
I think it's correct as-is, but just to double-check, this is meant to be 3, and not 4? Since the sequence here is bullet_3_img, bullet_3_img, bullet_5_img. I guess since it's the same image as the previous bullet point, it's sensible for it to also have the same alt text?
There was a problem hiding this comment.
yeah I was on the fence about whether to change the name to something like "bullet_3_4_img" to make it clearer but ultimately thought that was still a little weird and it would be redundant to have it written in the translation doc twice
There was a problem hiding this comment.
Yeah and as mentioned in the previous pull request, it'd be good to move away from the "bullet_#" convention anyways, so wouldn't want to make that harder.
All good then 👍
changelog: Accessibility, alt tags, add ssn alt tag (acceptance for LG-5774)
2 participants
One tweak for LG-6120 found during acceptance, we were missing an alt tag for ssn key image even though alt tags were added for all images next to it. Since image is the same as one above, I used the same yaml translation reference See slack thread here.