Revise password confirmation "Forgot Password" as link#6387
Merged
Conversation
aduth
force-pushed
the
aduth-forgot-password-link
branch
from
a5c5966 to
e617f60
Compare
**Why**: Because it looks and behaves like a link, it should carry semantics of a link, supporting native behavior such as opening in a new tab. changelog: Upcoming Features, Identity Verification, Add password confirmation step
**Why**: So we don't have to deal with distinctness by basePath, and for better guarantees that getStepParam and getParamURL behaves as expected as a result of setting.
Support undefined step value
Avoid extra confusion, since it's meant to be assigned by the component implementation
So we can render "Go Back" as a link as well
Because, similarly, it has a navigable destination
Previously, client-side routing would append trailing slash
aduth
force-pushed
the
aduth-forgot-password-link
branch
from
e617f60 to
85ab6a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Because it looks and behaves like a link, it should carry semantics of a link, supporting native behavior such as opening in a new tab.