Run integration specs for feature-flagged password confirm step#6383
Merged
Run integration specs for feature-flagged password confirm step#6383
Conversation
**Why**: So that we can be aware of potential issues sooner than later, we should re-run existing feature specs for IdV screens on the feature-flagged implementations. changelog: Upcoming Features, Identity Verification, Add password confirmation step
mitchellhenke
approved these changes
May 19, 2022
aduth
commented
May 19, 2022
Comment on lines
+131
to
+133
| expect(page).to have_content('October 6, 1938') | ||
| expect(page).to have_content(DocAuthHelper::GOOD_SSN) | ||
| expect(page).to have_content('(202) 555-1212') |
Contributor
Author
There was a problem hiding this comment.
Note that the new implementation does format some content a bit different from before, but not different enough that we should care?
identity-idp/spec/features/idv/steps/review_step_spec.rb
Lines 22 to 24 in 0dbc747
This is how client-side behaves (currently)
aduth
commented
May 20, 2022
| click_button t('idv.forgot_password.link_text') | ||
| click_button t('idv.forgot_password.try_again') | ||
|
|
||
| expect(page.current_path).to eq "#{idv_app_path(step: :password_confirm)}/" |
Contributor
Author
There was a problem hiding this comment.
Have to add the trailing slash here, since that's how the client-side routing currently behaves (recently revised in #6374). I'm looking to change this again as part of #6387 so that we won't need to do this (strip the trailing slash).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that we can be aware of potential issues sooner than later, we should re-run existing feature specs for IdV screens on the feature-flagged implementations.
These specs caught two issues already, addressed separately in #6374 and #6381.