LG-6274: Allow users to select phone as their sole second option

[jmdembe]

This ticket fixes a bug that emerged after #6278 and #6276 were completed

Current state: In setting up an account, the user would select one 2FA method (except for phone due to Kantara requirements). Once setup is complete, if the user selects the option to add a second MFA method, they will not be proceed with phone setup due to the validation added for

Future state: If the user selects phone as their sole additional authentication method, the user will be able to select the phone option and proceed with setup.

After

[aduth]

For mixed operators like || and &&, can we add parentheses around the parts which are meant to be tested together? I don't know the order of operations off the top of my head, so this is hard for me to interpret.

Also, we could return the boolean result directly, rather than extra return statement.

Suggested change

	if count >= 2 || count == 1 && MfaContext.new(user).phone_configurations.none?
	return true
	else
	return false
	end
	count >= 2 || (count == 1 && MfaContext.new(user).phone_configurations.none?)

[aduth]

Is the parentheses meaningful here?

Suggested change

	(IdentityConfig.store.select_multiple_mfa_options &&
	phone_selected? && phone_only_mfa_method?) &&
	!phone_alternative_enabled?
	IdentityConfig.store.select_multiple_mfa_options &&
	phone_selected? &&
	phone_only_mfa_method? &&
	!phone_alternative_enabled?

[jmdembe]

The parenthesis stayed around as I was refactoring

[aduth]

LGTM 👍

[aduth]

The loops here don't seem to be necessary for a single item, and in the second case we're already not using the loop parameter.

Suggested change

	%w[phone].each do |selection|
	result = subject.submit(selection: selection)
	expect(result.success?).to eq false
	end
	end
	end
	context 'when a user wants to select phone as their second authentication method' do
	let(:user) { create(:user, :with_authentication_app) }
	before do
	allow(IdentityConfig.store).to receive(:select_multiple_mfa_options).and_return(true)
	end
	it 'submits the form' do
	%w[phone].each do |selection|
	result = subject.submit(selection: ['phone'])
	expect(result.success?).to eq true
	end
	result = subject.submit(selection: ['phone'])
	expect(result.success?).to eq false
	end
	end
	context 'when a user wants to select phone as their second authentication method' do
	let(:user) { create(:user, :with_authentication_app) }
	before do
	allow(IdentityConfig.store).to receive(:select_multiple_mfa_options).and_return(true)
	end
	it 'submits the form' do
	result = subject.submit(selection: ['phone'])
	expect(result.success?).to eq true