Complete path for users to setup an additional method#6276
Conversation
jmdembe
force-pushed
the
jd-finish-sad-path
branch
from
15c96a0 to
da42ea6
Compare
changelog: Upcoming feature, multi-factor-authentication, complete sad path
jmdembe
force-pushed
the
jd-finish-sad-path
branch
from
da42ea6 to
4a5a48f
Compare
jmdembe
force-pushed
the
jd-finish-sad-path
branch
2 times, most recently
from
cd9656c to
01ab424
Compare
jmdembe
force-pushed
the
jd-finish-sad-path
branch
from
01ab424 to
9393561
Compare
| class MfaSelectionController < ApplicationController | ||
| include UserAuthenticator | ||
| include MfaSetupConcern | ||
|
|
There was a problem hiding this comment.
can we ensure user is authenticated.
We also want to ensure that users arrive at this page properly.
before_action :authenticate_user before_action :confirm_user_authenticated_for_2fa_setup
There was a problem hiding this comment.
can we ensure user is authenticated. We also want to ensure that users arrive at this page properly.
before_action :authenticate_user before_action :confirm_user_authenticated_for_2fa_setup
Was this suggestion implemented?
There was a problem hiding this comment.
it had been originally, but I believe what happened is that with a merge that I had to make with another PR that it got lost in a merge somewhere. I created a patch in LG-6236
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, a few comments
| end | ||
| let(:current_sp) { create(:service_provider) } | ||
|
|
||
| describe 'GET index' do |
There was a problem hiding this comment.
style, I'd name it like this:
| describe 'GET index' do | |
| describe '#index' do |
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
jmdembe
force-pushed
the
jd-finish-sad-path
branch
from
7398b50 to
25fb7bb
Compare
jmdembe
force-pushed
the
jd-finish-sad-path
branch
from
236981d to
0f9cee5
Compare
jmdembe
force-pushed
the
jd-finish-sad-path
branch
from
0f9cee5 to
25f05a0
Compare
4 participants
This PR closes the loop with regards to completing multi factor authentication setup.
Previously, once the user returned to the to the MFA setup page and selected an additional option, they would be re-directed to the account page leaving them unable to set up their account. We are now allowing for additional method setup that will lead to a confirmation that setup is complete.
Notes:
This work is being done in parallel with LG-6208/PR LG-6208: support interstitial work for users who select 1 mfa method #6284. The PR can be found here
Additional context:
https://gsa-tts.slack.com/archives/C01710KMYUB/p1650660265083359?thread_ts=1650659258.240019&cid=C01710KMYUB, specifically point 2