Conversation
There was a problem hiding this comment.
this should use the new method, not the string, right?
analytics.idv_gpo_address_visited(letter_already_sent: @presenter.letter_already_sent?)
There was a problem hiding this comment.
Ah yes - updated.
app/services/analytics_events.rb
Outdated
There was a problem hiding this comment.
We try to call this flow "GPO" now, the string was left to have consistency in event names
| # USPS address letter requested | |
| # GPO address letter requested |
There was a problem hiding this comment.
Ah ok. They've been updated.
app/services/analytics_events.rb
Outdated
There was a problem hiding this comment.
| # USPS address submitted | |
| # GPO address submitted |
app/services/analytics_events.rb
Outdated
There was a problem hiding this comment.
| # USPS address visited | |
| # GPO address visited |
gsa-manish
force-pushed
the
LG-5935-document-analytics-16
branch
from
4f48240 to
0a9dd34
Compare
app/services/analytics_events.rb
Outdated
There was a problem hiding this comment.
This event had a # Previously: note...
IDV_GPO_VERIFICATION_SUBMITTED = 'IdV: GPO verification submitted' # Previously: "Account verification submitted"
can we annotate that as well?
| # @param [Boolean] success | |
| # @param [Hash] errors | |
| # @param [Hash] pii_like_keypaths | |
| # GPO verification submitted | |
| def idv_gpo_verification_submitted( | |
| # @identity.idp.previous_event_name Account verification submitted | |
| # @param [Boolean] success | |
| # @param [Hash] errors | |
| # @param [Hash] pii_like_keypaths | |
| # GPO verification submitted | |
| def idv_gpo_verification_submitted( |
There was a problem hiding this comment.
Added to the annotation.
There was a problem hiding this comment.
Please take a look at my suggested comment, we have a specific YARD tag for this, @identity.previous_event_name
There was a problem hiding this comment.
Oh I see it now. Suggested comment added.
gsa-manish
force-pushed
the
LG-5935-document-analytics-16
branch
2 times, most recently
from
48e123a to
a0f65d2
Compare
changelog: Analytics, Events, update events #16
gsa-manish
force-pushed
the
LG-5935-document-analytics-16
branch
from
a0f65d2 to
2a99ccd
Compare
3 participants
changelog: Analytics, Events, update events #16