Conversation
|
Thanks for adding this. Could you please also update the README with usage instructions? |
|
removed rfr tag, there's a few more things coming down the pipeline. |
code/upaya/Dockerfile
Outdated
|
|
||
| ADD . /upaya | ||
| WORKDIR /upaya | ||
| RUN bundler install --without deploy |
There was a problem hiding this comment.
Copy the Gemfile first.. then run bundler, then copy the rest of the app. That means the bundler command will only be run when the Gemfile changes:
There is the one I'm working on:
FROM rails:4.2.6
MAINTAINER Eric Maland eric.maland@gsa.gov
WORKDIR /upaya
RUN mkdir /myapp
COPY Gemfile /upaya
COPY Gemfile.lock /upaya
RUN bundler install --without deployment deploy test
COPY . /upaya
EXPOSE 3000
CMD ["rails", "server", "-b", "0.0.0.0"]
|
LG-enoughTM |
| * Initialize your database: `docker run --link postgres --rm upaya rake db:setup` | ||
| * Run your app: `docker run --link postgres --rm upaya` | ||
| * Run your app, mounting your local repo in the container: `docker run --link postgres --rm -v $(pwd):/upaya` | ||
| * Run a shell in that container instead: `docker run --link postgres --rm -ti -v $(pwd):/upaya bash` |
There was a problem hiding this comment.
Most of this stuff is no longer needed with docker compose. Same with the database config. I'm happy to update to compose once this lands if you prefer. I have a WIP branch: https://github.com/18F/identity/tree/sbc_docker_compose
There was a problem hiding this comment.
Please do! I was just porting this PR over when I realized it wasn't built with docker compose.
There was a problem hiding this comment.
Also, do you mind including the go_script for performing all of these docker initialization commands? I'd like to be able to launch the app and run the specs with a single command.
|
+1 for using compose. Setup should involve the least amount of manual steps, and we should strive to automate as much of it as possible. |
|
Closing in favor of fresh PR from @sbc100 with docker-compose and go_script |
|
I would encourage reopening this largely for OS X users - docker-compose has a number of problems, which I can document if necessary. |
|
I'd be curious to hear about the problems. Sam's PR that I merged recently seemed to work fine for me on OS X. |
|
Yes, please open an issue detailing any problems. I don't have mac myself but can hop on one temporarily if needed. |
changelog: Analytics, Events, update events #16
changelog: Analytics, Events, update events #16
LG-269 Add CloudHSM to saml_idp gem
6 participants
No description provided.