Conversation
Contributor
|
There's quite a few lint and typecheck errors from the failing build. Could you check on those? |
aduth
reviewed
May 12, 2022
app/javascript/packages/verify-flow/steps/password-confirm/password-confirm-step.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/verify-flow/steps/password-confirm/password-confirm-step.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/verify-flow/steps/password-confirm/password-confirm-step.tsx
Outdated
Show resolved
Hide resolved
aduth
approved these changes
May 16, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Most concerned with addressing (1) bordered and (2) nested content markup, but otherwise looking in good shape 👍
app/javascript/packages/verify-flow/steps/password-confirm/password-confirm-step.spec.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/verify-flow/steps/password-confirm/password-confirm-step.spec.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/verify-flow/steps/password-confirm/password-confirm-step.spec.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/verify-flow/steps/password-confirm/password-confirm-step.tsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/verify-flow/steps/password-confirm/personal-info-summary.tsx
Outdated
Show resolved
Hide resolved
aduth
reviewed
May 17, 2022
app/javascript/packages/verify-flow/steps/password-confirm/password-confirm-step.tsx
Outdated
Show resolved
Hide resolved
aduth
approved these changes
May 17, 2022
Comment on lines
-9
to
+12
| interface PasswordConfirmStepStepProps extends FormStepComponentProps<VerifyFlowValues> {} | ||
| interface PasswordConfirmStepProps extends FormStepComponentProps<VerifyFlowValues> {} |
Contributor
There was a problem hiding this comment.
Nice catch / fix on the duplication of "StepStep" 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the accordion to password confirm pag