Skip to content

Drop unused types for sp_costs#6322

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/drop-some-sp-costs
May 9, 2022
Merged

Drop unused types for sp_costs#6322
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/drop-some-sp-costs

Conversation

@mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented May 6, 2022

Re-implements #6264 and #6266 (effectively reverting #6313)

Changes were discussed here

changelog: Internal, Optimization, Do not create sp_costs for unused cost types
@mitchellhenke mitchellhenke force-pushed the mitchellhenke/drop-some-sp-costs branch from fea0268 to 6eb44ad Compare May 6, 2022 22:15
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitchellhenke mitchellhenke changed the title Drop unused types for sp_costs (WIP) Drop unused types for sp_costs May 9, 2022
@mitchellhenke mitchellhenke merged commit 2bd9626 into main May 9, 2022
@mitchellhenke mitchellhenke deleted the mitchellhenke/drop-some-sp-costs branch May 9, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants