Merged
Conversation
jmhooper
approved these changes
Apr 27, 2022
mitchellhenke
force-pushed
the
mitchellhenke/drop-some-sp-costs
branch
from
d6908e7 to
627e18f
Compare
changelog: Internal, Optimization, Do not create sp_costs for unused cost types
mitchellhenke
force-pushed
the
mitchellhenke/drop-some-sp-costs
branch
from
627e18f to
3da7120
Compare
aduth
reviewed
Apr 28, 2022
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
changelog: Internal, Optimization, Do not create sp_costs for unused cost types
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
changelog: Internal, Optimization, Do not create sp_costs for unused cost types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We create a lot of rows in
sp_costsbut do not currently use them for any reporting. The removed types account for around 79% of the total rows, so this should save a significant amount of overhead on the database side.