Show IdV app alert message relevant for current step#6311
Merged
Conversation
**Why**: So that the personal key success alert message won't be shown for all steps, as we continue to expand the flow. changelog: Upcoming Features, Identity Verification, Add password confirmation step
aduth
force-pushed
the
aduth-verify-flow-status
branch
from
d568ba5 to
8c5c753
Compare
Avoid clunky switch assignment See: #6311 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that the personal key success alert message won't be shown for all steps, as we continue to expand the flow.
This builds on #6239, where a goal was to avoid including success banner in the implementation of the step itself, since steps could possibly be reused elsewhere (e.g. account dashboard personal key reset) and the display of a success banner is more a reflection of transition between steps as opposed to the step itself.
Screenshot
(Note: There's not expected to be any visual effect of these changes)