LG-6192 Add alert banner for successful completion of Password Entry#6239
Merged
LG-6192 Add alert banner for successful completion of Password Entry#6239
Conversation
changelog: Upcoming Features, Identity Verification, add sucess alert for password confirm
aduth
reviewed
Apr 22, 2022
Comment on lines
+19
to
+23
| {customElements.get('lg-step-indicator') && ( | ||
| <Alert type="success" className="margin-bottom-4"> | ||
| {t('idv.messages.confirm')} | ||
| </Alert> | ||
| )} |
Contributor
There was a problem hiding this comment.
Another idea for having it only show up in the verify flow is maybe to render this in the parent component instead (app/javascript/packages/verify-flow/index.tsx)? I could imagine we eventually may have a "Flash" mechanism live there, but I think it'd be fine to just have the static confirmation message for now.
Contributor
Author
There was a problem hiding this comment.
Gotcha, yes that makes sense. I moved it there 👍
aduth
reviewed
Apr 22, 2022
| <StepIndicatorStep title="Secure your account" status={StepStatus.CURRENT} /> | ||
| </StepIndicator> | ||
| <Alert type="success" className="margin-bottom-4"> | ||
| {t('idv.messages.confirm')} |
Contributor
There was a problem hiding this comment.
This will be your friend: 😄
https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode#format-on-save
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LG-6192 Add alert banner for successful completion of Password Entry
Why: We need to let the user know that their data has been encrypted after they enter their password
Testing Instructions
Screenshot
Note
This is a draft PR because I'm not sure about my idea for handling the fact that users can reset their personal key after they go through the steps. Since we don't want to display the alert in that scenario, I thought this maybe could be handled by simply checking if the step indicator element is present or not. Major assumption being that resetting the personal key does not involve its own multi step flow (I tried looking for it in the account dashboard to confirm but couldn't seem to find it)