Rename reactivate account session :personal_key key to be more descriptive#6283
Merged
mitchellhenke merged 1 commit intomainfrom May 2, 2022
Merged
Conversation
mitchellhenke
requested review from
aduth,
jmhooper,
mdiarra3,
stevegsa and
zachmargolis
changelog: Internal, Maintenance, Rename session key to be clearer
mitchellhenke
force-pushed
the
mitchellhenke/rename-reactivate-account-personal-key-key
branch
from
d8dbf16 to
1bf85d1
Compare
mitchellhenke
deleted the
mitchellhenke/rename-reactivate-account-personal-key-key
branch
peggles2
pushed a commit
that referenced
this pull request
May 3, 2022
changelog: Internal, Maintenance, Rename session key to be clearer
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
changelog: Internal, Maintenance, Rename session key to be clearer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A slight followup to #6273. The primary motivation is to rename the key so it doesn't give the appearance of holding a personal key, and it's also an opportunity to rename to something slightly more descriptive.
This will also be a two-part change where we write to both keys on the next deploy, and then start reading the new location and stop writing the old one in the deploy after.