Move more PII bundle usage to the common interface in Pii::Cacher#6273
Merged
mitchellhenke merged 1 commit intomainfrom Apr 29, 2022
Merged
Conversation
changelog: Internal, Security, Improve consistency in storing and fetching PII bundle from user session
mitchellhenke
commented
Apr 28, 2022
| reactivate_account_session[:pii] = pii.to_json | ||
| pii_json = pii.to_json | ||
| reactivate_account_session[:pii] = pii_json | ||
| Pii::Cacher.new(@user, session).save_decrypted_pii_json(pii_json) |
Contributor
Author
There was a problem hiding this comment.
This will write the value in both places, and after the next deploy, we can remove reactivate_account_session[:pii] and change the decrypted_pii to read from Pii::Cacher
Contributor
Author
There was a problem hiding this comment.
One side effect of this is if the person is going through account reactivation while authenticating for an SP that's requesting IDV attributes, they will have the decrypted_pii in the expected spot, and after copying their new personal key and clicking "Continue to $SP", they won't have to enter their password again because the PII is already decrypted in the expected location.
jmhooper
approved these changes
Apr 29, 2022
This was referenced May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #6054 to update places where we store a PII bundle to use the
Pii::Cacher: