Remove the USPS option during IAL2 strict#6277
Merged
Conversation
There is a chance we won't be able to roll out a compliant IAL2 flow with the USPS letter flow in place. This commit adds the ability to remove the letter flow option from strict IAL2 if that does become the case.
aduth
reviewed
Apr 29, 2022
solipet
reviewed
Apr 29, 2022
…oof with a letter during IAL2 strict was added
…tion to proof with a letter during IAL2 strict was added
…tion to proof with a letter during IAL2 strict was added
zachmargolis
reviewed
May 2, 2022
| def profile_needs_verification? | ||
| return false if current_user.blank? | ||
| return false if sp_session[:ial2_strict] && | ||
| !IdentityConfig.store.usps_upload_allowed_for_strict_ial2 |
Contributor
There was a problem hiding this comment.
is it too late to rename this feature flag? we switched everything using the mail-in flow to be called "GPO" to differentiate from IPP @ USPS #4837
stevegsa
approved these changes
May 2, 2022
aduth
reviewed
May 2, 2022
|
|
||
| # rubocop:disable Naming/MemoizedInstanceVariableName | ||
| def set_gpo_letter_available | ||
| @gpo_letter_available ||= FeatureManagement.enable_gpo_verification? && |
Contributor
There was a problem hiding this comment.
Same thing existed previously, but won't this reassign the instance variable if called repeatedly while still false?
Should it be... ?
Suggested change
| @gpo_letter_available ||= FeatureManagement.enable_gpo_verification? && | |
| @gpo_letter_available &&= FeatureManagement.enable_gpo_verification? && |
Contributor
Author
There was a problem hiding this comment.
I ended up going with this because of some quirks with the &&= operator:
[1] pry(main)> a &&= true
=> nil
[2] pry(main)> a
=> nil
peggles2
pushed a commit
that referenced
this pull request
May 5, 2022
There is a chance we won't be able to roll out a compliant IAL2 flow with the USPS letter flow in place. This commit adds the ability to remove the letter flow option from strict IAL2 if that does become the case. * changelog: Upcoming Features, Proofing, The ability to disable the option to proof with a letter during IAL2 strict was added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a chance we won't be able to roll out a compliant IAL2 flow with the USPS letter flow in place. This commit adds the ability to remove the letter flow option from strict IAL2 if that does become the case.