Skip to content

Remove unused string interpolation for personal key text #6196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 3 commits into from
Apr 13, 2022
Merged

Remove unused string interpolation for personal key text #6196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20947cd
Remove unused string interpolation for personal key text
aduth Apr 13, 2022
7411684
Remove unnecessary _html suffix
aduth Apr 13, 2022
0ceac00
Remove double-spaces after sentence
aduth Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions app/views/shared/_personal_key.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
<%= render PageHeadingComponent.new.with_content(t('headings.personal_key')) %>
<p>
<%= t(
'instructions.personal_key.info_html',
accent: content_tag(:strong, t('instructions.personal_key.accent')),
) %>
<%= t('instructions.personal_key.info') %>
</p>
<div class="full-width-box margin-y-5">
<%= render 'partials/personal_key/key', code: code %>
Expand Down
9 changes: 4 additions & 5 deletions config/locales/instructions/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,11 @@ en:
iv: Good
v: Great!
personal_key:
accent: Write it down or print it out.
email_body: Don’t lose your personal key or share it with others. We’ll ask for
email_body: Don’t lose your personal key or share it with others. We’ll ask for
it if you reset your password.
email_title: Save it. Keep it safe.
info_html: You’ll need this personal key if you forget your password. If you
reset your password and don’t have this key, you’ll have to verify your
email_title: Save it. Keep it safe.
info: You’ll need this personal key if you forget your password. If you reset
your password and don’t have this key, you’ll have to verify your
identity again.
sp_handoff_bounced: Your sign in was successful, but %{sp_name} sent you back to
%{app_name}. Please contact %{sp_link} for help.
Expand Down
7 changes: 3 additions & 4 deletions config/locales/instructions/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,12 @@ es:
iv: Buena
v: '¡Muy buena!'
personal_key:
accent: Anótala o imprímela.
email_body: No pierdas tu clave personal ni la compartas con otros. La pediremos
si restableces tu contraseña.
email_title: Guárdala. Manténla segura.
info_html: Necesitarás esta clave personal si olvidas tu contraseña. Si
restableces tu contraseña y no tienes esta clave, deberás verificar tu
identidad nuevamente.
info: Necesitarás esta clave personal si olvidas tu contraseña. Si restableces
tu contraseña y no tienes esta clave, deberás verificar tu identidad
nuevamente.
sp_handoff_bounced: Su inicio de sesión fue exitoso, pero %{sp_name} lo envió de
regreso a %{app_name}. Póngase en contacto con %{sp_link} para obtener
ayuda.
Expand Down
7 changes: 3 additions & 4 deletions config/locales/instructions/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,13 @@ fr:
iv: Bonne
v: Excellente!
personal_key:
accent: Notez-la ou imprimez-la.
email_body: Ne perdez pas votre clé personnelle et ne la partagez pas avec
d’autres. Nous vous le demanderons si vous réinitialisez votre mot de
passe.
email_title: Sauvegarde le. Garde-le en sécurité.
info_html: Vous aurez besoin de cette clé personnelle si vous oubliez votre mot
de passe. Si vous réinitialisez votre mot de passe et que vous ne
possédez pas cette clé, vous devrez vérifier votre identité à nouveau.
info: Vous aurez besoin de cette clé personnelle si vous oubliez votre mot de
passe. Si vous réinitialisez votre mot de passe et que vous ne possédez
pas cette clé, vous devrez vérifier votre identité à nouveau.
sp_handoff_bounced: Votre connexion a réussi, mais %{sp_name} vous a renvoyé à
%{app_name}. Veuillez contacter %{sp_link} pour obtenir de l’aide.
sp_handoff_bounced_with_no_sp: votre fournisseur de service