Remove unused string interpolation for personal key text#6196
Merged
Conversation
**Why**: Since there is no "accent" interpolation key in the "instructions.personal_key.info_html" string. changelog: Internal, Localization, Remove unused locale strings
zachmargolis
approved these changes
Apr 13, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! The _html part of info_html is no longer needed right?
Contributor
Author
Ah, good call! I'll update to remove it. |
aduth
added a commit
that referenced
this pull request
Apr 14, 2022
* Move PageHeading to components package For reuse in verify-flow * Add basic FormSteps flow for IdV React implementation **Why**: So that we can start implementing step screens for the new, React-based identity verification flow. changelog: Upcoming Features, Identity Verification, Add personal key step screen * Initialize React I18nContext with global locale data * Add basic personal key step content * Fix imports * Update test default i18n context * Set default I18nContext value to shared i18n instance * Import t directly Moving toward potential future removal of useI18n * Remove unnecessary string interpolation https://github.com/18F/identity-idp/pull/6195/files#r849653819 * Update usage for I18nContext.Provider Previously receives strings object, now receives I18n instance * Update personal_key info string key Changed in #6196 * Reorder props Bit easier to read with className last
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Since there is no
accentinterpolation key in theinstructions.personal_key.info_htmlstring:identity-idp/config/locales/instructions/en.yml
Lines 107 to 109 in 402f116