Skip to content

Fix CSP for Rails mailer previews#5852

Merged
zachmargolis merged 2 commits intomainfrom
margolis-fix-mailer-preview-csp
Jan 24, 2022
Merged

Fix CSP for Rails mailer previews#5852
zachmargolis merged 2 commits intomainfrom
margolis-fix-mailer-preview-csp

Conversation

@zachmargolis
Copy link
Contributor

Re: #5844 (comment)

The Rails mailer previews use inline CSS style, so we need to allow them in order to have previews work. Would be nice if we could scope these changes to certain URLs, but this works for now:

before after
Screen Shot 2022-01-24 at 12 56 04 PM Screen Shot 2022-01-24 at 12 53 45 PM
Screen Shot 2022-01-24 at 12 56 14 PM Screen Shot 2022-01-24 at 12 54 38 PM

Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
@zachmargolis zachmargolis requested a review from aduth January 24, 2022 21:14
Copy link
Contributor

@jmhooper jmhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, my b for breaking this

@zachmargolis zachmargolis merged commit ddbc075 into main Jan 24, 2022
@zachmargolis zachmargolis deleted the margolis-fix-mailer-preview-csp branch January 24, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants