Skip to content

Refactor the CSP allow list tooling to better reduce CSP and preserve schemes#5842

Merged
jmhooper merged 9 commits intomainfrom
jmhooper-csp-allow-list-refactor
Jan 21, 2022
Merged

Refactor the CSP allow list tooling to better reduce CSP and preserve schemes#5842
jmhooper merged 9 commits intomainfrom
jmhooper-csp-allow-list-refactor

Conversation

@jmhooper
Copy link
Contributor

@jmhooper jmhooper commented Jan 21, 2022

Why: So we do not have repetitive and unnecessary URLs in our form action directive. This change also improves handling of mobile app schemes and preserves the schemes to ensure https is enforced on destinations unless the scheme is explicitly http.

… schemes

**Why**: So we do not have repetitive and unnecessary URLs in our form action directive. This change also improves handling of mobile app schemes and preserves the schemes to ensure https is enforced on destinations unless the scheme is explicitly http.
@jmhooper jmhooper changed the title Refactor the CSP allow list tooling to better reduce CSP and preserve… Refactor the CSP allow list tooling to better reduce CSP and preserve schemes Jan 21, 2022
@jmhooper
Copy link
Contributor Author

jmhooper commented Jan 21, 2022

This is a companion to #5757 and will help to reduce complexity in that PR

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmhooper jmhooper merged commit d22b85a into main Jan 21, 2022
@jmhooper jmhooper deleted the jmhooper-csp-allow-list-refactor branch January 21, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants