Replace SecureHeaders CSP tooling with built in Rails tooling#5757
Merged
Replace SecureHeaders CSP tooling with built in Rails tooling#5757
Conversation
**Why**: So that we can use the baked in Rails behavior for managing the CSP.
aduth
reviewed
Jan 7, 2022
zachmargolis
reviewed
Jan 7, 2022
aduth
reviewed
Jan 14, 2022
jmhooper
commented
Jan 14, 2022
This was referenced Jan 21, 2022
Contributor
Author
|
Okay, I finally have everything passing and think this is finally ready to go |
zachmargolis
approved these changes
Jan 24, 2022
| default_csp_config[:script_src] = ["'self'", "'unsafe-eval'"] if !Rails.env.production? | ||
|
|
||
| if IdentityConfig.store.rails_mailer_previews_enabled | ||
| default_csp_config[:style_src] << "'unsafe-inline'" |
Contributor
There was a problem hiding this comment.
oo thanks for cleaning up here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that we can use the baked in Rails behavior for managing the CSP.
This commit includes a feature flag so we can test this without potentially breaking the world.