Skip to content

Also allow 666 prefix in mock proofer #5698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 2 commits into from
Dec 20, 2021
Merged

Also allow 666 prefix in mock proofer #5698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
533e2f2
also allow 666 prefix in mock proofer
Dec 10, 2021
8e4ff37
Update config/locales/doc_auth/es.yml
Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/services/proofing/mock/resolution_mock_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ class ResolutionMockClient < Proofing::Base
end

# To reduce the chances of allowing real PII in the mock proofer, we only allow SSNs that
# start with 900 or appear in the configurable allow list
# start with 900 or 666 or appear in the configurable allow list
def verified_ssn?(ssn)
ssn.start_with?('900') ||
ssn.start_with?('900', '666') ||
Copy link
Contributor

@orenyk orenyk Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: were you still going to add tests for this?

Copy link
Contributor Author

@mitchellhenke mitchellhenke Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to, but couldn't find an easy place to test it. It doesn't look like the mock proofers have direct specs, and they are only tested via other specs. We probably should though?

IdentityConfig.store.test_ssn_allowed_list.include?(ssn.delete('-'))
end
end
Expand Down
2 changes: 1 addition & 1 deletion config/locales/doc_auth/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ en:
send_sms: We’ll send a text message to your device with a link. Follow that
link to your browser to take photos of the front and back of your ID.
switch_back: Switch back to your computer to finish verifying your identity.
test_ssn: In the test environment only SSNs that begin with “900-” are
test_ssn: In the test environment only SSNs that begin with “900-” or “666-” are
considered valid. Do not enter real PII in this field.
text1: ''
text1a: such as a phone or computer.
Expand Down
4 changes: 2 additions & 2 deletions config/locales/doc_auth/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,8 @@ es:
trasera de su identificación.
switch_back: Regrese a su computadora para continuar con la verificación de su
identidad.
test_ssn: En el entorno de prueba solo los SSN que comienzan con “900-” se
consideran válidos. No ingrese PII real en este campo.
test_ssn: En el entorno de prueba solo los SSN que comienzan con “900-” o “666-”
se consideran válidos. No ingrese PII real en este campo.
text1: ''
text1a: como un teléfono o una computadora.
text2: No es necesario disponer de la credencial.
Expand Down
5 changes: 3 additions & 2 deletions config/locales/doc_auth/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,9 @@ fr:
ce lien vers votre navigateur pour prendre des photos du recto et du
verso de votre identifiant.
switch_back: Retournez sur votre ordinateur pour continuer à vérifier votre identité.
test_ssn: Dans l’environnement de test seuls les SSN commençant par “900-” sont
considérés comme valides. N’entrez pas de vrais PII dans ce champ.
test_ssn: Dans l’environnement de test seuls les SSN commençant par “900-” ou
“900-” sont considérés comme valides. N’entrez pas de vrais PII dans ce
champ.
text1: ''
text1a: tel qu’un téléphone ou un ordinateur
text2: Vous n’aurez pas besoin de la carte avec vous.
Expand Down