Skip to content

LG-5372 Follow on minor update to action button whitespace #5639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amathews-fs merged 2 commits into from
Nov 24, 2021
Merged

LG-5372 Follow on minor update to action button whitespace #5639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
578af33
LG-5372 Follow on minor update to action button top and bottom white …
amathews-fs Nov 24, 2021
d539441
LG-5372 CSS suggestions
amathews-fs Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/idv/doc_auth/agreement.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<%= validated_form_for :doc_auth,
url: url_for,
method: 'put',
html: { autocomplete: 'off', class: 'margin-top-2 js-consent-continue-form' } do |f| %>
html: { autocomplete: 'off', class: 'margin-top-2 margin-bottom-5 js-consent-continue-form' } do |f| %>
<div class="margin-bottom-4">
<%= check_box_tag(
:ial2_consent_given,
Expand Down
5 changes: 2 additions & 3 deletions app/views/idv/doc_auth/welcome.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
</div>
</div>
</li>
<li class='padding-top-2 padding-bottom-1'>
<li class='padding-top-2'>
<div class="grid-row">
<div class='grid-col-2 margin-right-2 text-top circle-number bg-primary text-white'>
<%= step += 1 %>
Expand All @@ -79,8 +79,7 @@
<%= validated_form_for :doc_auth,
url: url_for,
method: 'put',
html: { autocomplete: 'off', class: 'margin-top-2 js-consent-continue-form' } do |f| %>
<br/>
Copy link
Copy Markdown
Contributor

@aduth aduth Nov 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 to removal of <br>

Copy link
Copy Markdown
Contributor Author

@amathews-fs amathews-fs Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even see it when I was messing with all of that. I'm not even certain why it was all in there.

html: { autocomplete: 'off', class: 'margin-y-5 js-consent-continue-form' } do |f| %>
<%= f.button :button,
t('doc_auth.buttons.continue'),
type: :submit,
Expand Down