LG-5372 Follow on minor update to action button whitespace#5639
LG-5372 Follow on minor update to action button whitespace#5639amathews-fs merged 2 commits intomainfrom
Conversation
| url: url_for, | ||
| method: 'put', | ||
| html: { autocomplete: 'off', class: 'margin-top-2 js-consent-continue-form' } do |f| %> | ||
| <br/> |
There was a problem hiding this comment.
I didn't even see it when I was messing with all of that. I'm not even certain why it was all in there.
| method: 'put', | ||
| html: { autocomplete: 'off', class: 'margin-top-2 js-consent-continue-form' } do |f| %> | ||
| <br/> | ||
| html: { autocomplete: 'off', class: 'margin-top-4 padding-bottom-1 js-consent-continue-form' } do |f| %> |
There was a problem hiding this comment.
If the idea is there should be 5 units of margin around the button, maybe we can do...
| html: { autocomplete: 'off', class: 'margin-top-4 padding-bottom-1 js-consent-continue-form' } do |f| %> | |
| html: { autocomplete: 'off', class: 'margin-y-5 js-consent-continue-form' } do |f| %> |
This seems to collapse as expected.
The only problem is that there's extra padding on the last list item on the welcome step, but it seems like we can / should remove that.
| url: url_for, | ||
| method: 'put', | ||
| html: { autocomplete: 'off', class: 'margin-top-2 js-consent-continue-form' } do |f| %> | ||
| html: { autocomplete: 'off', class: 'margin-top-2 padding-bottom-1 js-consent-continue-form' } do |f| %> |
There was a problem hiding this comment.
Similar, we could do margin-bottom-5 and rely on collapsing margins.
| html: { autocomplete: 'off', class: 'margin-top-2 padding-bottom-1 js-consent-continue-form' } do |f| %> | |
| html: { autocomplete: 'off', class: 'margin-top-2 margin-bottom-5 js-consent-continue-form' } do |f| %> |
Doesn't make much a difference, though I think could be easier to think about the form having 2.5rem bottom margin, vs. a combination of its 0.5rem bottom-padding and the next element's 2rem top-margin.
There was a problem hiding this comment.
Mmmm, yeah, I get that. I should have been thinking about it as the large margin would set the distance. The margin collapsing thing is not something I think about normally.
2 participants
LG-5372 Follow on minor update to action button top and bottom white space.