Skip to content

Remove instances of "h1" BassCSS class #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 2 commits into from
Nov 18, 2021
Merged

Remove instances of "h1" BassCSS class #5614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54b21a3
Remove instances of "h1" BassCSS class
aduth Nov 17, 2021
c02921b
Render device-choice subheading as h2.font-family-sans
aduth Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .erb-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ linters:
- 'btn(-(small|big|narrow|wide|link|primary|secondary|danger|disabled|big|narrow|transparent|border))?'
- '(border|bg)-(none|black|gray|silver|aqua|blue|navy|teal|green|olive|lime|orange|red|fuchsia|purple|maroon|darken-[1-4]|lighten-[1-4])'
- 'bg-(cover|contain|center|top|right|bottom|left)'
- 'h([03]|00)'
- 'h([013]|00)'
Comment thread
aduth marked this conversation as resolved.
- 'h([01]|00)-responsive'
suggestion: 'Use USWDS classes instead of BassCSS.'
- deprecated:
Expand Down
4 changes: 2 additions & 2 deletions app/views/idv/doc_auth/upload.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@
<%= t('doc_auth.info.tag') %>
</div>
<div class='sm-col sm-col-9'>
<div class='bold h1 margin-y-105'>
<h2 class="font-family-sans margin-y-105">
<% if liveness_checking_enabled? %>
<%= t('doc_auth.headings.upload_from_phone_liveness_enabled') %>
<% else %>
<%= t('doc_auth.headings.upload_from_phone') %>
<% end %>
</div>
</h2>
<%= t('doc_auth.info.upload_from_phone') %>
<br/>
<%= validated_form_for(
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_no_pii_banner.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div class='h1 padding-y-4 bg-secondary-darker text-white fs-12p line-height-1 center'>
<div class="font-sans-lg padding-y-4 bg-secondary-darker text-white line-height-1 text-center">
<%= t('idv.messages.sessions.no_pii') %>
</div>
6 changes: 3 additions & 3 deletions app/views/users/piv_cac_authentication_setup/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<div class='inline-block margin-right-2 margin-top-1 text-top circle-number bg-primary text-white'>
1
</div>
<label class="h1 margin-right-1 inline-block margin-bottom-1 bold" for="nickname">
<label class="font-sans-lg margin-right-1 display-inline-block margin-bottom-1 text-bold" for="nickname">
<%= t('instructions.mfa.piv_cac.step_1') %>
</label>
<div class='margin-left-6 margin-bottom-1'>
Expand All @@ -25,7 +25,7 @@
2
</div>
<div class='margin-right-1 inline-block margin-bottom-2'>
<div class='h1 inline-block bold'>
<div class="font-sans-lg display-inline-block text-bold">
<%= t('instructions.mfa.piv_cac.step_2') %>
</div>
</div>
Expand All @@ -36,7 +36,7 @@
3
</div>
<div class='margin-right-1 inline-block'>
<div class='h1 inline-block bold'>
<div class="font-sans-lg display-inline-block text-bold">
<%= t('instructions.mfa.piv_cac.step_3') %>
</div>
</div>
Expand Down