Skip to content

Increase TOTP secret length from 80 bits to 160 bits #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 3 commits into from
Nov 12, 2021
Merged

Increase TOTP secret length from 80 bits to 160 bits #5604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31cff6f
Increase TOTP secret length from 80 bits to 160 bits
jmhooper Nov 12, 2021
08005ea
fix a spec
jmhooper Nov 12, 2021
d9192b9
Use `random` instead of `random_base32`
jmhooper Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/concerns/user_otp_methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def create_direct_otp
end

def generate_totp_secret
ROTP::Base32.random_base32(16)
ROTP::Base32.random(20)
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we left a comment here describing the # of bits?#5604

Suggested change
ROTP::Base32.random(20)
ROTP::Base32.random(20) # 160-bit secret, per RFC 4226

end

def authenticate_direct_otp(code)
Expand Down
2 changes: 1 addition & 1 deletion spec/models/user_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@
it 'generates a secret 16 characters long' do
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis Nov 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this spec title is now wrong

Suggested change
it 'generates a secret 16 characters long' do
it 'generates a secret 32 characters long' do

user = build(:user)
secret = user.generate_totp_secret
expect(secret.length).to eq 16
expect(secret.length).to eq 32
end
end

Expand Down