Refactor document capture provider hierarchy via component composition#5535
Merged
Refactor document capture provider hierarchy via component composition#5535
Conversation
**Why**: Flattening results in diffs which aren't as unyieldy when adding or removing from the component hierarchy.
aduth
commented
Oct 22, 2021
Comment on lines
+142
to
+143
| const App = composeComponents([ | ||
| [AppContext.Provider, { value: appContext }], |
Contributor
Author
There was a problem hiding this comment.
I considered a version that preserved JSX, but unfortunately it doesn't always work as nice with component typing which enforces that children be passed. We can control this for our own components, but it's quite likely to be something we'd encounter if ever using third-party components.
const App = composeComponents([
<AppContext.Provider value={appContext} />,
**Why**: Avoid verbose equivalent TypeScript casting
**Why**: Destructures the same, avoids explicit reference to undefined (which by definition is more on the implicit end "absence of" a defined value, vs. explicit empty null), smaller bundled size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Flattening results in diffs which aren't as unyieldy when adding or removing from the component hierarchy.