-
Notifications
You must be signed in to change notification settings - Fork 167
Idea: JSON API to serve current SMS/voice support #5523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ca21ed3
Add /api/country-support for SMS/voice support
zachmargolis a528151
fix origins for development
zachmargolis 89cbbee
lints
zachmargolis 7f58c89
Make test more specific about response structure
zachmargolis ff22865
Update config/application.rb
zachmargolis af119cd
Fix CORS specs, anchor domains
zachmargolis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| class CountrySupportController < ApplicationController | ||
| def index | ||
| render json: { countries: PhoneNumberCapabilities::INTERNATIONAL_CODES } | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| require 'rails_helper' | ||
|
|
||
| RSpec.describe CountrySupportController do | ||
| describe '#index' do | ||
| it 'renders country support as JSON' do | ||
| get :index | ||
|
|
||
| json = JSON.parse(response.body, symbolize_names: true) | ||
|
|
||
| expect(json[:countries][:US]).to eq( | ||
| name: 'United States', | ||
| country_code: '1', | ||
| supports_sms: true, | ||
| supports_voice: true, | ||
| ) | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| require 'rails_helper' | ||
|
|
||
| RSpec.describe 'CORS headers for OpenID Connect endpoints' do | ||
| describe '/api/country-support' do | ||
| before do | ||
| get api_country_support_path, headers: { 'HTTP_ORIGIN' => http_origin } | ||
| end | ||
|
|
||
| context 'origin is www.login.gov' do | ||
| let(:http_origin) { 'https://www.login.gov' } | ||
|
|
||
| it 'allows origin' do | ||
| aggregate_failures do | ||
| expect(response['Access-Control-Allow-Origin']).to eq(http_origin) | ||
| expect(response['Access-Control-Allow-Methods']).to eq('GET') | ||
| end | ||
| end | ||
| end | ||
|
|
||
| context 'origin is login.gov' do | ||
| let(:http_origin) { 'https://login.gov' } | ||
|
|
||
| it 'allows origin' do | ||
| aggregate_failures do | ||
| expect(response['Access-Control-Allow-Origin']).to eq(http_origin) | ||
| expect(response['Access-Control-Allow-Methods']).to eq('GET') | ||
| end | ||
| end | ||
| end | ||
|
|
||
| context 'origin is federalist preview' do | ||
| let(:http_origin) { 'https://federalist-abcdef.app.cloud.gov' } | ||
|
|
||
| it 'allows origin' do | ||
| aggregate_failures do | ||
| expect(response['Access-Control-Allow-Origin']).to eq(http_origin) | ||
| expect(response['Access-Control-Allow-Methods']).to eq('GET') | ||
| end | ||
| end | ||
| end | ||
|
|
||
| context 'origin is local in development' do | ||
| let(:http_origin) { 'http://127.0.0.1:4000' } | ||
|
|
||
| it 'allows origin' do | ||
| aggregate_failures do | ||
| expect(response['Access-Control-Allow-Origin']).to eq(http_origin) | ||
| expect(response['Access-Control-Allow-Methods']).to eq('GET') | ||
| end | ||
| end | ||
| end | ||
|
|
||
| context 'origin is not allowed' do | ||
| let(:http_origin) { 'https://foo.com' } | ||
|
|
||
| it 'does not allow origin' do | ||
| aggregate_failures do | ||
| expect(response).to be_ok | ||
| expect(response['Access-Control-Allow-Origin']).to be_nil | ||
| end | ||
| end | ||
| end | ||
|
|
||
| context 'origin includes but is not login.gov' do | ||
| let(:http_origin) { 'https://login.gov.evil.com' } | ||
|
|
||
| it 'does not allow origin' do | ||
| aggregate_failures do | ||
| expect(response).to be_ok | ||
| expect(response['Access-Control-Allow-Origin']).to be_nil | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a TODO if we do LG-5223 we need to make sure to update this part as well